server: use seconds instead of nano seconds for expires_in and expiry #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithujohn191
requested changes
Nov 4, 2016
| // we can predict expected values of "expires_in" fields exactly. | ||
| now := func() time.Time { return t0 } | ||
|
|
||
| idTokensValidFor := time.Second * 30 |
There was a problem hiding this comment.
Maybe a small comment explaining why it is initialized to this value would help.
ericchiang
force-pushed
the
fix-server-time-bug
branch
from
a8a514f
to
12a5c0a
Compare
ericchiang
commented
Nov 5, 2016
| // we can predict expected values of "expires_in" fields exactly. | ||
| now := func() time.Time { return t0 } | ||
|
|
||
| // Used later when configuring test servers to set how long id_tokens will be valid for. |
There was a problem hiding this comment.
@rithujohn191 does this clarify this field?
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.