connector: add GitLab connecor #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
givia
commented
Jan 25, 2017
givia
commented
| // Open returns a strategy for logging in through GitLab. | ||
| func (c *Config) Open(logger logrus.FieldLogger) (connector.Connector, error) { | ||
| return &gitlabConnector{ | ||
| baseURL: c.BaseURL, |
There was a problem hiding this comment.
would you like to provide a default value for baseURL that corresponds to the public gitlab API URL? This would be helpful if the user does not provide one via the config.
ericchiang
reviewed
Jan 26, 2017
| name: GitLab | ||
| config: | ||
| # Credentials can be string literals or pulled from the environment. | ||
| baseURL: https://www.gitlab.com |
There was a problem hiding this comment.
Add a note that this is optional
ericchiang
reviewed
Jan 26, 2017
| } | ||
|
|
||
| var gitlabGroups []gitlabGroup | ||
| if err := json.NewDecoder(resp.Body).Decode(&gitlabGroups); err != nil { |
There was a problem hiding this comment.
Does gitlab do pagination? ref #706
givia
force-pushed
the
gitlab-connector
branch
from
e899140
to
8e4fbab
Compare
|
Successfully tested https://github.com/coreos/dex/tree/master/cmd/example-app with the new gitlab connector 👍 Groups scope works as well |
|
Would be great if you could squash your commits. Thanks |
givia
force-pushed
the
gitlab-connector
branch
from
555a27c
to
e623ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.