Fix assertion fallback #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calpicow
force-pushed
the
fix_assertion_fallback
branch
from
c41891f
to
22f0d48
Compare
|
@Calpicow do you have a test case which demonstrates this? I'd like to avoid regressions. |
|
Yes, I'll add some tests. |
Calpicow
force-pushed
the
fix_assertion_fallback
branch
from
22f0d48
to
0d7d624
Compare
|
Tests added |
|
Edit: Appears to be regression in goxmldsig |
|
@Calpicow looking into this now |
Calpicow
force-pushed
the
fix_assertion_fallback
branch
from
0d7d624
to
fa6e6a7
Compare
Calpicow
force-pushed
the
fix_assertion_fallback
branch
from
fa6e6a7
to
965bfb0
Compare
|
Tests are passing |
ericchiang
reviewed
Mar 24, 2017
connector/saml/saml.go
Outdated
| @@ -500,8 +501,8 @@ func verify(validator *dsig.ValidationContext, data []byte) (signed []byte, err | |||
| verified = true | |||
| doc.SetRoot(transformedResponse) | |||
| } | |||
| assertion := response.SelectElement("Assertion") | |||
| if assertion == nil { | |||
| assertion, err := etreeutils.NSSelectOne(response, "urn:oasis:names:tc:SAML:2.0:assertion", "Assertion") | |||
There was a problem hiding this comment.
Can you comment a little more on what this change is doing and why it's required?
Calpicow
force-pushed
the
fix_assertion_fallback
branch
from
965bfb0
to
6f9ef96
Compare
|
Updated. How's that? |
|
perfect, thanks. |
ericchiang
approved these changes
Mar 24, 2017
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Fix assertion fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where all xmlns are contained within the top level element.