connector: Connectors without a RefreshConnector should not error out #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithujohn191
force-pushed
the
offline-access-error
branch
2 times, most recently
from
2b5a21f
to
4826fb3
Compare
ericchiang
reviewed
Mar 23, 2017
server/handlers.go
Outdated
| @@ -647,7 +647,15 @@ func (s *Server) handleAuthCode(w http.ResponseWriter, r *http.Request, client s | |||
|
|
|||
| reqRefresh := func() bool { | |||
| for _, scope := range authCode.Scopes { | |||
| if scope == scopeOfflineAccess { | |||
| conn, ok := s.connectors[authCode.ConnectorID] | |||
There was a problem hiding this comment.
Can you add a comment here?
There was a problem hiding this comment.
Also this check needs to happen outside the for loop :)
rithujohn191
force-pushed
the
offline-access-error
branch
2 times, most recently
from
c6ee5fb
to
10b1c1f
Compare
ericchiang
reviewed
Mar 23, 2017
| s.tokenErrHelper(w, errServerError, "", http.StatusInternalServerError) | ||
| return false | ||
| } | ||
| _, ok = conn.Connector.(connector.RefreshConnector) |
There was a problem hiding this comment.
You can short circuit this.
if !ok {
return false
}
This avoids the loop in some cases.
…refresh token instead of erroring
rithujohn191
force-pushed
the
offline-access-error
branch
from
10b1c1f
to
5950285
Compare
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
connector: Connectors without a RefreshConnector should not error out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #871.
Tested this change by running the example-app with okta. The "Creating SAML data: SAML does not support offline access" error is no longer displayed. The example app does not display a refresh token on the final out put page.