Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connector/ldap: add LDAP integration tests #900

Merged
merged 3 commits into from Apr 10, 2017
Merged

connector/ldap: add LDAP integration tests #900

merged 3 commits into from Apr 10, 2017

Conversation

ericchiang
Copy link
Contributor

No description provided.

@ericchiang
Copy link
Contributor Author

cc @rithujohn191

rithujohn191
rithujohn191 approved these changes Apr 10, 2017
View reviewed changes
Copy link
Contributor

@rithujohn191 rithujohn191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is going to be so helpful. Thanks

@ericchiang ericchiang merged commit 7395f05 into dexidp:master Apr 10, 2017
@ericchiang ericchiang deleted the ldap-tests branch April 10, 2017 23:48
@ericchiang ericchiang mentioned this pull request Apr 10, 2017
Closed
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
@ericchiang
Merge pull request dexidp#900 from ericchiang/ldap-tests
021b25a 
connector/ldap: add LDAP integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithujohn191 rithujohn191 rithujohn191 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericchiang @rithujohn191