bugfix: avoid generating an invalid ID attribute in SAML's AuthenRequest element #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay be used as a SAML's ID attribute
kkohtaka
changed the title
srenatus
approved these changes
Jul 10, 2017
ericchiang
approved these changes
Jul 10, 2017
|
Thank you for the change. |
|
Thanks for reviewing and merging. Do you have a specific schedule to release a next version? |
kkohtaka
pushed a commit
to zlabjp/dex
that referenced
this pull request
Jul 19, 2017
bugfix: avoid generating an invalid ID attribute in SAML's AuthenRequest element
|
@kkohtaka Latest release is available at https://github.com/coreos/dex/releases/tag/v2.5.0 |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
bugfix: avoid generating an invalid ID attribute in SAML's AuthenRequest element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team is going to use Azure AD as an IdP with SAML 2.0 connector. However, when the connector sends an AuthnRequest to Azure AD's endpoint, Azure AD often responds with an error message such as
The request is not a valid Saml2 protocol message.After a brief investigation, I found that the connector often generates an AuthnRequest whose ID attribute starts with a digit though such an ID attribute is forbidden by the XML specification. The ID attribute is originally generated by
storage.NewID()and this PR will change the behavior of the function to avoid generating an ID which starts with a digit.Refs: https://www.w3.org/TR/REC-xml/#sec-attribute-types