Documentation: add a group query example for the ldap connector. #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericchiang do you want me to replace |
|
Added an LDIF object example to clarify "DN". Also moved the example to the config section. |
ericchiang
reviewed
Jul 13, 2017
Documentation/ldap-connector.md
Outdated
| # Optional filter to apply when searching the directory. | ||
| filter: "(objectClass=group)" | ||
|
|
||
| userAttr: dc=example,dc=com # Use "DN" here not "uid" |
There was a problem hiding this comment.
This needs to be
userAttr: DN
|
@ericchiang any additional change suggestions? |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Documentation: add a group query example for the ldap connector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of people seem to be confused about how they should implement group specific queries. Thought it would be nice to have this as part of our docs.