server/rotation.go: Fix key rotation with multiple dex instances. #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
reviewed
Jul 19, 2017
server/rotation.go
Outdated
| @@ -15,6 +16,8 @@ import ( | |||
| "github.com/coreos/dex/storage" | |||
| ) | |||
|
|
|||
| var errAlreadyRotated = errors.New("key already rotated by another instance of Dex") | |||
There was a problem hiding this comment.
nit:
s/key/keys/g
s/another instance of Dex/another server instance/g
rithujohn191
force-pushed
the
fix-key-rotation
branch
from
1fe1e38
to
753526a
Compare
This was referenced Jul 19, 2017
|
From the changes it looks like this was cosmetic not an actual bug? Is that true? |
|
@robszumski returning |
|
@robszumski Adding to that its necessary to have more than one instance of Dex to reproduce this bug. Its not an issue if the user has only one replica of Dex |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
server/rotation.go: Fix key rotation with multiple dex instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #976.
It also ensures that it displays "keys already rotated" as an info log message instead of an error message.