-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Inconsistent image tagging in Helm chart appVersion #125
Comments
Although this is taken care of in the deployment template here, I agree it would be easier to use the same tag as version. I'm not entirely sure I understand how it impedes you, though. |
We have an automatic update mechanism that looks at this repo's releases, matches the release with Other projects to it the same way - examples: Don't get me wrong, it ca be vX.Y.Z or X.Y.Z, but at least consistent between the Chart.yaml and index.yaml |
You mean git tag and appVersion, don't you? |
So probably also that would have to be unified as well.. 😅 But we are not consuming that, attribute. I'm refering to Chart.yaml and index.yaml. |
I don't see how Chart.yaml and index.yaml can differ. index.yaml is created based on Chart.yaml. When no tag is specified in values, the prefix is automatically prepended to the value of appVersion. What we can do, is remove that automatic prefixing and use the full tag in appVersion instead. Can't really change anything else. Not sure if this would solve your problem though. |
That would definitely help! 😄 |
Hi @sagikazarmark, do you need any help with this? I can provide a PR if you think it's worthwhile. |
@nabokihms what do you think? I'm not against the above outlined solution. |
I'm ok with this change if we speak about removing the automatic |
Hi. Any news here? |
Preflight Checklist
Chart
dex
Version
v2.37.0
Expected Behavior
Consistent tagging between appVersion and image tag between
Chart.yaml
andvalues.yaml
.Actual Behavior
Currently, releases contain Helm charts which have Chart.yaml
appVersion: "X.YY.Z"
. But the values.yaml tag references a different format (vX.YY.Z
), also instructing users that if you don't specify anything, the appVersion is used.We are automatically updating upstream charts with PRs which are automatically opened in our internal repos, this behavior impedes us.
Please help. Thank you.
Steps To Reproduce
No response
Additional Information
No response
Values
No response
The text was updated successfully, but these errors were encountered: