Skip to content

Commit

Permalink
Add explanatory comment and remove TODO message
Browse files Browse the repository at this point in the history
  • Loading branch information
jayaddison authored and dfahlander committed Oct 14, 2020
1 parent a9f030a commit 1f2cad1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions addons/Dexie.Observable/src/Dexie.Observable.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,7 @@ function Observable(db) {
}
}

// TODO: Why is this safety check required?
// Without it, this test fails: https://github.com/dfahlander/Dexie.js/blob/77f0b08c58784bfaaf9e2f5e26dd4e1d7b7d3094/test/tests-exception-handling.js#L411-L494
// ... due to an unhandled global TypeError: Cannot read property 'id' of null
// The local node reference may be unassigned at any point by a database close() operation
if (!mySyncNode.node) return;

// Assign the local node state
Expand Down

0 comments on commit 1f2cad1

Please sign in to comment.