Modification object in updating hook not correct when changing array

[Christilut]

See https://jsfiddle.net/ygaprkbe/2/

In the console you will see {} but it should be the object in the update call.

So far I've only seen this when updating items inside of an array.

Also, most likely a related bug: https://jsfiddle.net/ygaprkbe/3/

The modifications object here is { foo.bar: 444 } which seems similar to this old bug #1195

[dfahlander]

Thanks! I see what's wrong here. Arrays of objects compare equal due to getValueOf() only supporting arrays of simple types. The commit that fixed #1195 did compare arrays using getValueOf(). Might need to extend getValueOf() to support objects and go nested.

TODO:

1. Create a repro test in test-crud-hooks.js or extend the existing "issue Update with array as value adds number objects #1195 Update with array as value adds number objects".
2. Extend getValueOf() to support "Object". Would be tempting to do JSON.stringify() but that wouldnt support binary types so better to do a nested call to getValueOf().