#1105 Allow readonly arrays for bulk put & get methods #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Yes all tests pass for this PR: https://travis-ci.org/github/dfahlander/Dexie.js/builds/720915693. Question: Do we need to use |
|
@dfahlander good catch, indeed - fixed. |
|
@dfahlander For some reason, the check seems to be stuck... Is it normal or should the CI be relaunched? |
|
Thanks for the fix! Yes, I don't know why the github/travis integration seem to be faulty. The build went fine anyway https://travis-ci.org/github/dfahlander/Dexie.js/builds/720938812 so I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1105
@dfahlander You mentioned that it's going to be a tsc error, but seemingly the build and tests all pass without any errors.