Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow middleware hooks to return objects that contained field names that contain dotted strings #1130

Merged
merged 10 commits into from
Sep 29, 2020
Merged

Allow middleware hooks to return objects that contained field names that contain dotted strings #1130

merged 10 commits into from
Sep 29, 2020

Commits on Sep 25, 2020

  1. Cleanup: ensure db.folks update hook is removed after unit test compl… 

    …etes
    @jayaddison
    jayaddison committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    77d2411 View commit details
    Browse the repository at this point in the history

  2. Do not extract nested paths from the object keys contained in middlew… 

    …are hook return values

Fixes #966
    @jayaddison
    jayaddison committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    e6def57 View commit details
    Browse the repository at this point in the history

  3. Additional test for #1130

    @dfahlander
    dfahlander committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    7e17a73 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Merge branch 'master' into fixes/issue-966

    @jayaddison
    jayaddison committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    052a38b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/additional-test-for-1130' into… 

    … fixes/issue-966
    @jayaddison
    jayaddison committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    8a146c7 View commit details
    Browse the repository at this point in the history

  3. Nit: trailing space

    @jayaddison
    jayaddison committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    999c221 View commit details
    Browse the repository at this point in the history

  4. Post-merge fixup

    @jayaddison
    jayaddison committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    4e9c16c View commit details
    Browse the repository at this point in the history

  5. Add explicit check for keys as literal property names on objects befo… 

    …re intepreting them as paths
    @jayaddison
    jayaddison committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    3eda88a View commit details
    Browse the repository at this point in the history

  6. Alternative approach: push logic down into setByKeyPath function

    @jayaddison
    jayaddison committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    d610245 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Revert "Alternative approach: push logic down into setByKeyPath funct… 

    …ion"

This reverts commit d610245.
    @jayaddison
    jayaddison committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    0065aa6 View commit details
    Browse the repository at this point in the history