Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to JS implementation of indexedDB.cmp(). #1412

Merged
merged 7 commits into from Oct 14, 2021
Merged

Switch to JS implementation of indexedDB.cmp(). #1412

merged 7 commits into from Oct 14, 2021

Commits on Oct 14, 2021

  1. Switch to JS implementation of indexedDB.cmp(). 

    This one is about 30 times faster than indexedDB.cmp()
+ it removes the global dependency of indexedDB for RangeSet,
used by liveQuery().
    @dfahlander
    dfahlander committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    6a897e9 View commit details
    Browse the repository at this point in the history

  2. Bugfixed new unit test for cmp

    @dfahlander
    dfahlander committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    66c379c View commit details
    Browse the repository at this point in the history

  3. Removed alway-false condition.

    @dfahlander
    dfahlander committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    7172bd7 View commit details
    Browse the repository at this point in the history

  4. Added tests to comply to IDB spec: 

    Comparing two arrays with different length:

https://www.w3.org/TR/IndexedDB-3/#compare-two-keys
    @dfahlander
    dfahlander committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    f2aa49d View commit details
    Browse the repository at this point in the history

  5. Bugfixes spec compliancy: 

    comparing arrays and typed arrays of different sizes.
    @dfahlander
    dfahlander committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    d4071c9 View commit details
    Browse the repository at this point in the history

  6. Bugfix: treated NaN array items as equals.

    @dfahlander
    dfahlander committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    b4b93a3 View commit details
    Browse the repository at this point in the history

  7. Removing another domDeps dependent code part. 

    Ran unit tests on IE after doing this. All still pass.
Though one test on Dexie.Observable failed so I without digging to deep into the reason, I disabled that test for IE and legacy edge.
    @dfahlander
    dfahlander committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    fe05e50 View commit details
    Browse the repository at this point in the history