Upgrade QUnit #384
Merged
Upgrade QUnit #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed the paths in karma.conf and run-unit-tests to point to the version which will be downloaded via npm.
Also added the options that were previously in qunit to QUnit.config.urlConfig. This should address the comments in dexie#381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error mentioned in #381 by upgrading QUnit + moving to a packaged version. We should now also be able to update more easily to 2.0 (though there are some breaking changes).
Testing done:
run-unit-tests.htmlnpm run testandnpm run test:debug.npm run test:debug