Review and bugfix Dexie.Observable and Dexie.Syncable #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendMessage() did wait for non-indexeddb async task within a transaction which didn't lead to any complaints in Dexie 1.x but now fails with PrematureCommitError. For general stability of sendMessage(), it's no more trying to reuse any existing transaction. Instead it will always spawn its own transaction. Also, in case caller is within non-awaited transaction, sendMessage will not block that transaction (Sounds wierd? What do I mean with non-awaited transaction? I mean a transaction block that don't return a promise, which will make db.transaction() use Promise.follow() to join what's happening. sendMessage() will now generate and wait for promises in a Dexie.ignoreTransaction() zone which makes it not being waited for by Promise.follow().
Now the dexie tests run fine with syncable addon active in chrome. http://localhost:8080/addons/Dexie.Syncable/test/test-syncable-dexie-tests.html
Reverted to functions for IE to be able to parse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.