Make dexie typings extendable by addons #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added [Symbol.toStringTag] property to Promise.prototype (in js and d.ts). Removed Promise.onuncatched from d.ts. Added Promise.timeout in d.ts.
Dexie.Promise is now compatible with Promise interface in lib.es2015.promise.d.ts and lib.es2015.symbol.wellknown.d.ts. Also: * More strict checks of transaction modes. * Correction of Dexie.waitFor() to use PromiseLike instead of Promise. * Simplified the declaration of all methods that have a 'then-shortcut-callback' as its last argument such as Table.get(), Table.toArray() etc.
Implemented Dexie.d.ts so that addons can extend events and API with Typescript 2.1 (See #213). Made a d.ts file for dexie-observable that does extend the dexie typings according to its API. Next step will be to implement d.ts also for dexie-syncable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #213. Now it's possible to extend the dexie API from an addon.
I've implemented this with dexie-observable so far. Next step: dexie-syncable.