Stop using localStorage for recording database names #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now backing Dexie.getDatabaseNames() in indexedDB instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dexie.getDatabaseNames() polyfills indexedDB.getDatabaseNames() for on non-chromium browsers. To do this, it adds the name of every opened table into a localStorage property. Silly not to use an indexedDB database? Reason may have been because I was allergic to storing meta-data in indexedDB. But it's actually even more ridiculous to store it in localStorage so I've moved it to use indexedDB (database '__dbnames') for recording database names so that the feature works in workers as well.
The code size went actually smaller with this change, so I think it's in the right path.
This change will automatically migrate existing localStorage data into the new __dbnames table.