Fix IndexedDB 2.0 unit tests #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some backround: The Dexie unit tests for binary key support (IndexedDB 2) was written by spec before they were released on browsers. The tests had bugs so that when browsers came out with binary key support the unit tests started failing. This commit fixes the broken unit tests and also fixes an issue with Dexie to fully support binary primary keys in or-queries.
I've found a bug in FF55 where it wont allow calling IDBObjectStore.get() or IDBObjectStore.delete() passing a binary key as argument. This has been reported as issue https://bugzilla.mozilla.org/show_bug.cgi?id=1395071 The binary keys tests now avoids calling these methods. They must also cleanup the added items in the tables as the test runner would otherwise stumble on FF bugs when resetting the database between tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.