fallback on Promise #810
Closed
fallback on Promise #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building against esNext window.Promise, Node.Promise etc. do not seem to exist, resulting in a runtime error in the code when running on Node. While this change could be regarded as a hack, it allows Dexie to run.
|
The problem is that Promise is defined locally so it would fallback to Dexie.Promise instead of the native Promise. Could be fixed by renaming function Promise to something else in promise.js. If so, we wouldn't have to pick _global.Promise at all but instead refer to it as just Promise. |
|
OK - thanks for the quick response. I'll close this pull request and open an issue. hopefully I get time to get around to it. I will have to have a much deeper look into the differences between a dexie.Promise and the ES native promise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building against esNext window.Promise, Node.Promise etc. do not seem to exist, resulting in a runtime error in the code when running on Node. While this change could be regarded as a hack, it allows Dexie to run.