New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEXI-2491: implemented configuration utility #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e from test. Also: * Removed "Properties" files because they are not hierarchical * Improved Javadoc
Also, created private convenience methods.
…tion file. Only read that one file when reading local configuration.
hofmeister
suggested changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looking good - just a few
hofmeister
suggested changes
Nov 15, 2018
* Naming suggestion change * Use test scope for "junit" dependency
* Added account info to configuration because the Dexi API SDK needs it * Changed default local configuration filename to something more intuitive
* Use new Config class in existing Dexi client code * Added getters for getting properties needed for the Dexi API SDK
…n a non-local resource.
* Fixed how configuration is read * Adapted reading of environment variables to "DEXI_APP_" (copied from Webi Config's "DEXI_" logic) * Ensured test reading environment variables check that later values overwrite earlier-specified values
hofmeister
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.