Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEXI-2491: implemented configuration utility #2

Merged
merged 19 commits into from Nov 16, 2018
Merged

DEXI-2491: implemented configuration utility #2

merged 19 commits into from Nov 16, 2018

Conversation

mortengf
Copy link
Contributor

No description provided.

Copy link
Contributor

@hofmeister hofmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looking good - just a few

src/main/java/io/dexi/config/Config.java Outdated Show resolved Hide resolved
src/main/java/io/dexi/config/Config.java Outdated Show resolved Hide resolved
src/main/java/io/dexi/config/Config.java Outdated Show resolved Hide resolved
src/main/java/io/dexi/config/Config.java Outdated Show resolved Hide resolved
src/main/java/io/dexi/config/Config.java Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
Morten Garbøl Franck added 8 commits November 15, 2018 12:57
* Naming suggestion change
* Use test scope for "junit" dependency
* Added account info to configuration because the Dexi API SDK needs it
* Changed default local configuration filename to something more intuitive
* Use new Config class in existing Dexi client code
* Added getters for getting properties needed for the Dexi API SDK
* Fixed how configuration is read
* Adapted reading of environment variables to "DEXI_APP_" (copied from Webi Config's "DEXI_" logic)
* Ensured test reading environment variables check that later values overwrite earlier-specified values
Copy link
Contributor

@hofmeister hofmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/main/java/io/dexi/config/DexiConfig.java Outdated Show resolved Hide resolved
@mortengf mortengf merged commit aa7319a into master Nov 16, 2018
@mortengf mortengf deleted the dexi-2491 branch November 16, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants