Instant LP Unbonding #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betterclever
commented
May 29, 2023
contracts/keeper/src/contract.rs
Outdated
| recipient: Some(recipient), | ||
| exit_type: ExitType::ExactLpBurn { | ||
| lp_to_burn: amount, | ||
| min_assets_out: None |
There was a problem hiding this comment.
add support for min_asset_out slippage while exiting using Keeper
contracts/keeper/src/contract.rs
Outdated
| lp_token_address: Addr, | ||
| amount: Uint128, | ||
| sender: Addr, | ||
| recipient: Option<Addr> |
There was a problem hiding this comment.
unnecessary parameter in this context
| .add_attribute("amount", amount) | ||
| .add_attribute("total_bond_amount", lp_global_state.total_bond_amount) | ||
| .add_attribute("user_updated_bond_amount", user_updated_bond_amount) | ||
| .add_attribute("withdraw_fee", penalty_fee) |
There was a problem hiding this comment.
let's call it instant_unbond_fee rather than different nomenclatures
| use dexter::helper::EventExt; | ||
| use crate::state::CONFIG; | ||
|
|
||
| // Instant unlock is a extension of instant unbonding feature which allows to insantly unbond tokens |
contracts/multi_staking/src/utils.rs
Outdated
|
|
||
| /// Find the difference between two lock vectors. | ||
| /// This must take into account that same looking lock can coexist, for example, there can be 2 locks for unlocking | ||
| /// 100 tokens at block 100 boths. |
betterclever
force-pushed
the
betterclever/ft-instant-lp-unbonding
branch
from
fb97cd7
to
7fe3d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.