This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
Align memory for encryption to not corrupt nsz files compressed with zstd 1.5.0 and later #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h zstd 1.5.0 and later. This fixes dezem#34
|
Thanks @nicoboss for the fix😎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation of NSZ games compressed with zstd 1.5.0 or later results in corrupted installations. This issue occurs due to a memory misalignment of the encrypt functions input. With zstd 1.5.0 block splitting is used for compression level 16 and higher which is what causes the memory to get unaligned. This PR fixes this memory alignment issue.
This bug got discussed in length at nicoboss/nsz#120. All title installer with an NCA writer based on Adubbz Tinfoil are affected. This fix is based on the fix @blawar developed for Tinleaf and Tinfoil. I tested this with multiple games and it fixes the issue without any measurable performance impact. This PR fixes #34