Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block picking retains block states #209

Closed
DaPigGuy opened this issue Jul 18, 2021 · 0 comments · Fixed by #215
Closed

Block picking retains block states #209

DaPigGuy opened this issue Jul 18, 2021 · 0 comments · Fixed by #215
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@DaPigGuy
Copy link
Member

DaPigGuy commented Jul 18, 2021 •
edited

Picking any blocks retains block states it should not retain

Notable examples are:

  • Upper Parts of Double Plants/Doors
  • Open Doors/Trapdoors/Fence Gates
  • Crops at various growth stages
  • Sign Text

Only reproducible when item is not already in inventory
@DaPigGuy DaPigGuy added the bug Something isn't working label Jul 18, 2021
@DaPigGuy DaPigGuy changed the title Block picking retains block entity NBT Block picking retains block states Jul 18, 2021
@Sandertv Sandertv added this to the v? milestone Jul 18, 2021
@DaPigGuy DaPigGuy mentioned this issue Jul 20, 2021
Merged
Sandertv pushed a commit that referenced this issue Jul 20, 2021
@DaPigGuy
Fixed block picking retaining all block states (#209) (#215)
55818d3 
* Fixed block picking retaining block states & added NBT picking for block entities

* Removed NBT block picking
@DaPigGuy DaPigGuy modified the milestones: v?, v0.2.0 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Fixed block picking retaining all block states (#209) df-mc/dragonfly
2 participants
@DaPigGuy @Sandertv