Implemented skull block #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandertv
reviewed
Jan 9, 2022
server/block/skull.go
Outdated
Comment on lines
22
to
24
| Direction cube.Face | ||
| // Rotation is the number of rotations for skulls placed on the floor. There are a total of 16 rotations. | ||
| Rotation cube.Orientation |
There was a problem hiding this comment.
I think this should use the Attachment type. If I'm not mistaken the placement logic of skulls (roughly) matches that of signs.
JustTalDevelops
added
feature
|
Any update on this? |
89 tasks
|
I'm picking this up once I have the time. |
# Conflicts: # server/block/register.go # server/entity/physics/aabb.go
…lue would not drop any XP at all.
# Conflicts: # server/block/hash.go # server/block/register.go
Sandertv
removed
the
awaiting response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.