Implement smelting #508

JustTalDevelops · 2022-05-17T00:24:14Z

This PR implements smelting. (closes #499)

The smelting data is directly included in the item types instead of being loaded such as crafting recipes to include experience data and to avoid import cycles with the block and recipe packages.

…melting

JustTalDevelops · 2022-05-17T05:15:37Z

This is ready for review aside from the missing experience drops implementation.

server/block/blast_furnaces.go

Sandertv

I've left some more comments. Should be mostly ready once those are resolved.

server/block/container.go

server/block/furnace.go

server/block/smelter.go

server/block/smoker.go

server/item/smelting_info.go

server/block/furnace.go

# Conflicts: # go.mod # server/block/hash.go # server/block/register.go # server/session/handler_item_stack_request.go # server/session/player.go

…melting # Conflicts: # server/item/boots.go # server/item/chestplate.go # server/item/helmet.go # server/item/leggings.go

…respective functions.

DaPigGuy

Smelter blocks are not dropping their item contents on break

DaPigGuy

Small visual issue; if a player views a smelting block UI while it is cooking, exits, and views again after smelting is completely finished, the cooking time arrow will not reflect that it is finished

Sandertv

This looks good to me, I think it's ready to go.

JustTalDevelops and others added 18 commits May 16, 2022 17:40

dragonfly: Started smelting implementation.

af5b21b

recipe/register.go: Remove useless strconv.

446e6e9

block, item: Implemented Fuel in relevant items.

cc760c0

block, item: Implemented Smelt in relevant items.

10d3119

block/furnace.go: Created a basic furnace implementation.

35774c2

session/world.go: Remove debug.

ebf6e87

item/smelting_info.go: Removed the Regular field.

0dfdb36

block/smelter.go: Various fixes.

cce3d29

added missing smelting info for raw ore items

79f51f0

block/smelter.go: Properly handle regular residue.

a0a956f

Merge remote-tracking branch 'origin/feature/smelting' into feature/s…

cab823b

…melting

added missing smelting info for potatoes/kelp

a4f36ae

block: Added blast furnaces and smokers.

1879763

session/world.go: Fix container types.

3d2b14d

session/player.go: Fix invByID.

250245d

session/player.go: Various changes.

2657f81

block/smelter.go: Decrease cook duration with consideration of speed.

9b6028a

sound/block.go: Added crackling sounds for all smelters.

35e9279

JustTalDevelops marked this pull request as ready for review May 17, 2022 05:15

JustTalDevelops added 3 commits May 17, 2022 00:18

sliceutil/sliceutil.go: Removed unused changes.

9d6adbd

block/smelter.go: Various fixes.

4eeb8d4

block/register.go: Register Furnace as an item.

9c84f71

JustTalDevelops requested review from Sandertv, T14Raptor and DaPigGuy May 17, 2022 06:22

AndreasHGK reviewed May 17, 2022

View reviewed changes

server/block/blast_furnaces.go Outdated Show resolved Hide resolved

JustTalDevelops added 3 commits May 17, 2022 16:31

block/blast_furnaces.go: Renamed.

def8cd3

block/smelter.go: Directly take in requirement and decrement durations.

23f3613

block/smelter.go: Various changes.

752f37d

JustTalDevelops and others added 5 commits July 11, 2022 21:55

session/handler_item_stack_request.go: Correct collectRewards logic.

9897fce

introduce helper methods for smelting info

d43f36b

introduce helper methods for fuel info

b11fd9d

Merge branch 'master' into feature/smelting

8fd782a

fixed build errors

9c3a5b5

JustTalDevelops added the feature New feature or request label Jul 14, 2022

JustTalDevelops mentioned this pull request Jul 14, 2022

Vanilla Minecraft Feature Tracking #566

Open

89 tasks

Sandertv requested changes Jul 15, 2022

View reviewed changes

JustTalDevelops added 9 commits July 16, 2022 22:53

Merge branch 'master' into feature/smelting

91af87b

# Conflicts: # go.mod # server/block/hash.go # server/block/register.go # server/session/handler_item_stack_request.go # server/session/player.go

item: Compare armour tier type to account for changes.

ddbe7f7

Merge remote-tracking branch 'origin/feature/smelting' into feature/s…

0744555

…melting # Conflicts: # server/item/boots.go # server/item/chestplate.go # server/item/helmet.go # server/item/leggings.go

item/boots.go: Re-add EnchantmentValue.

3ae3120

block/container.go: Removed redundant XPContainer.

8c6939f

block/smelter.go: Unexported 'setExperience' and 'setDurations'.

8959dc7

item/smelting_info.go: Renamed 'Smelt' to 'Smeltable'.

40b038e

block: Updated docs to indicate smelters must be created using their …

92c4aac

…respective functions.

block/smelter.go: Document tickSmelting.

dc1559f

JustTalDevelops requested a review from Sandertv July 17, 2022 04:26

block/smelter.go: Move unexported functions down.

55ea8f0

DaPigGuy requested changes Jul 17, 2022

View reviewed changes

JustTalDevelops and others added 5 commits July 17, 2022 04:12

block/furnace.go: Drop items in inventory.

a48147e

block/blast_furnace.go: Drop items in inventory.

aae2bf8

block/furnace.go: Fix typo.

db76d77

block/smoker.go: Drop items in inventory

ad698a9

block: smelter blocks can be mined by hand

2beff18

DaPigGuy requested changes Jul 17, 2022

View reviewed changes

DaPigGuy approved these changes Jul 17, 2022

View reviewed changes

Sandertv approved these changes Jul 17, 2022

View reviewed changes

Sandertv merged commit 459112d into master Jul 17, 2022

Sandertv deleted the feature/smelting branch July 17, 2022 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement smelting #508

Implement smelting #508

JustTalDevelops commented May 17, 2022 •

edited

Loading

JustTalDevelops commented May 17, 2022

Sandertv left a comment

DaPigGuy left a comment

DaPigGuy left a comment

Sandertv left a comment

Implement smelting #508

Implement smelting #508

Conversation

JustTalDevelops commented May 17, 2022 • edited Loading

JustTalDevelops commented May 17, 2022

Sandertv left a comment

Choose a reason for hiding this comment

DaPigGuy left a comment

Choose a reason for hiding this comment

DaPigGuy left a comment

Choose a reason for hiding this comment

Sandertv left a comment

Choose a reason for hiding this comment

JustTalDevelops commented May 17, 2022 •

edited

Loading