Thorns enchantment

[HashimTheArab]

No description provided.

[HashimTheArab]

ill test this in like 15 hours, cant rn

[Sandertv]

Would like to have someone with a more thorough understanding of thorns to have a look at the logic.

[DaPigGuy]

Multiple worn armor items with the Thorns enchantment do stack. Each piece confers an independent chance to deal damage to the attacker as described above. The total amount of damage that can be dealt this way is capped at 4

[DaPigGuy]

The current implementation damages every armor piece that procs Thorns. The current implementation does not account for the Unbreaking enchantment

If multiple armor pieces are enchanted with Thorns, the durability penalty is applied to one piece chosen at random, regardless of what level of Thorns that piece has. If the item is also enchanted with Unbreaking, the damage penalty has a chance of being ignored.

[DaPigGuy]

The thornsDamage variable also seems redundant

[HashimTheArab]

The current implementation damages every armor piece that procs Thorns. The current implementation does not account for the Unbreaking enchantment

If multiple armor pieces are enchanted with Thorns, the durability penalty is applied to one piece chosen at random, regardless of what level of Thorns that piece has. If the item is also enchanted with Unbreaking, the damage penalty has a chance of being ignored.

Looking at the java source code, I'm not seeing any extra logic for unbreaking

ThornsEnchantment.java

public void doPostHurt(LivingEntity wearer, Entity attacker, int p_45217_) {
      RandomSource randomsource = wearer.getRandom();
      Map.Entry<EquipmentSlot, ItemStack> entry = EnchantmentHelper.getRandomItemWith(Enchantments.THORNS, wearer);
      if (shouldHit(p_45217_, randomsource)) {
         if (attacker != null) {
            attacker.hurt(DamageSource.thorns(wearer), (float)getDamage(p_45217_, randomsource));
         }

         if (entry != null) {
            entry.getValue().hurtAndBreak(2, wearer, (p_45208_) -> {
               p_45208_.broadcastBreakEvent(entry.getKey());
            });
         }
      }
}

ItemStack.java

public <T extends LivingEntity> void hurtAndBreak(int damage, T wearer, Consumer<T> p_41625_) {
      if (!wearer.level.isClientSide && (!(wearer instanceof Player) || !((Player)wearer).getAbilities().instabuild)) {
         if (this.isDamageableItem()) {
            if (this.hurt(damage, wearer.getRandom(), wearer instanceof ServerPlayer ? (ServerPlayer)wearer : null)) {
               p_41625_.accept(wearer);
               Item item = this.getItem();
               this.shrink(1);
               if (wearer instanceof Player) {
                  ((Player)wearer).awardStat(Stats.ITEM_BROKEN.get(item));
               }

               this.setDamageValue(0);
            }

         }
      }
}

public boolean isDamageableItem() {
      if (!this.emptyCacheFlag && this.getItem().getMaxDamage() > 0) {
         CompoundTag compoundtag = this.getTag();
         return compoundtag == null || !compoundtag.getBoolean("Unbreakable");
      } else {
         return false;
      }
}

public boolean hurt(int damage, RandomSource wearer, @Nullable ServerPlayer p_220160_) {
      if (!this.isDamageableItem()) {
         return false;
      } else {
         if (damage > 0) {
            int i = EnchantmentHelper.getItemEnchantmentLevel(Enchantments.UNBREAKING, this);
            int j = 0;

            for(int k = 0; i > 0 && k < damage; ++k) {
               if (DigDurabilityEnchantment.shouldIgnoreDurabilityDrop(this, i, wearer)) {
                  ++j;
               }
            }

            damage -= j;
            if (damage <= 0) {
               return false;
            }
         }

         if (p_220160_ != null && damage != 0) {
            CriteriaTriggers.ITEM_DURABILITY_CHANGED.trigger(p_220160_, this, this.getDamageValue() + damage);
         }

         int l = this.getDamageValue() + damage;
         this.setDamageValue(l);
         return l >= this.getMaxDamage();
      }
}

The stuff in hurt just looks like the general unbreaking code which in dragonfly is in player.damageItem

[Sandertv]

This looks good to me too.