Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement walls #559

Merged
merged 36 commits into from
Jul 29, 2022
Merged

Implement walls #559

merged 36 commits into from
Jul 29, 2022

Conversation

TwistedAsylumMC
Copy link
Member

No description provided.

@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 14, 2022
@DaPigGuy DaPigGuy mentioned this pull request Jul 14, 2022
Open
89 tasks
@TwistedAsylumMC
Merge branch 'master' into feature/walls
5e52212 
# Conflicts:
#	server/block/register.go
DaPigGuy
DaPigGuy requested changes Jul 22, 2022
View reviewed changes
server/block/wall.go Outdated Show resolved Hide resolved
server/block/model/wall.go Outdated Show resolved Hide resolved
@JustTalDevelops JustTalDevelops added the awaiting response More information is required to resolve and/or close the issue label Jul 22, 2022
@JustTalDevelops
Copy link
Member

Make sure you update the solid check @TwistedAsylumMC.

DaPigGuy
DaPigGuy requested changes Jul 24, 2022
View reviewed changes
server/block/model/trapdoor.go Outdated Show resolved Hide resolved
@JustTalDevelops JustTalDevelops removed the awaiting response More information is required to resolve and/or close the issue label Jul 26, 2022
DaPigGuy
DaPigGuy reviewed Jul 26, 2022
View reviewed changes
server/block/wall.go Outdated Show resolved Hide resolved
@DaPigGuy DaPigGuy requested a review from Sandertv July 26, 2022 10:09
Sandertv
Sandertv reviewed Jul 29, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a couple of comments. For the hash thing, I'm not entirely sure how to solve this. Maybe we could at least add a check somewhere to make sure it doesn't overflow and break silently.

cmd/blockhash/main.go Show resolved Hide resolved
server/block/wall_type.go Outdated Show resolved Hide resolved
server/block/wall_type.go Show resolved Hide resolved
@JustTalDevelops
Copy link
Member

Should probably also account for blast resistances now that explosions are merged.

Sandertv
Sandertv approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Thanks for the PR!

@Sandertv Sandertv merged commit 7410164 into master Jul 29, 2022
@Sandertv Sandertv deleted the feature/walls branch July 29, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy approved these changes

@Sandertv Sandertv Sandertv approved these changes

@JustTalDevelops JustTalDevelops JustTalDevelops approved these changes

@T14Raptor T14Raptor Awaiting requested review from T14Raptor

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TwistedAsylumMC @JustTalDevelops @DaPigGuy @Sandertv