-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented explosions #562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(all requested changes resolved)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a couple of comments. There's a lot of TODOs still so I won't do a super thorough review just yet. I do think the general idea here is good.
…/explosions # Conflicts: # server/block/block.go # server/block/explosion.go
Co-authored-by: Raptor <t14raptor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more changes that should probably be made:
-
Don't think we should remove the
* 5
when initializing BreakInfo, since all of the added blast resistances are also* 5
. I'd rather just/ 5
in the actual explosion code. I believe PM also does the same, would also be more consistent with BDS and whatnot. Also might cause issues if other areas of the code expect vanilla blast resistance values. -
Better names for
double7
anddouble8
, especially justdouble
, it doesn't make sense here. (assuming you took this from the Java code) -
Exposure is not being utilized. (if it's not working as intended, you might want to fix it too)
-
Would remove the remaining debug code.
Make sure you resolve the Radius usage in main.go or remove the debugging code. |
# Conflicts: # server/block/block.go # server/block/stone_bricks.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- No knock-back to players (at least, in creative mode)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine mostly. Got a couple of comments that should be pretty easy to resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small error in the refactor. Looks good otherwise, make sure to test once more to make sure all is right. Feel free to merge once you're confident it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Merge at your own discretion.
No description provided.