Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented explosions #562

Merged
merged 37 commits into from
Jul 29, 2022
Merged

Implemented explosions #562

merged 37 commits into from
Jul 29, 2022

Conversation

T14Raptor
Copy link
Member

No description provided.

@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 14, 2022
@DaPigGuy DaPigGuy mentioned this pull request Jul 14, 2022
89 tasks
@T14Raptor T14Raptor marked this pull request as ready for review July 14, 2022 23:56
Copy link
Member

@JustTalDevelops JustTalDevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(all requested changes resolved)

Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a couple of comments. There's a lot of TODOs still so I won't do a super thorough review just yet. I do think the general idea here is good.

server/block/break_info.go Show resolved Hide resolved
server/block/block.go Outdated Show resolved Hide resolved
server/block/block.go Outdated Show resolved Hide resolved
server/block/explosion.go Outdated Show resolved Hide resolved
server/block/explosion.go Outdated Show resolved Hide resolved
@JustTalDevelops JustTalDevelops self-requested a review July 16, 2022 03:34
Copy link
Member

@JustTalDevelops JustTalDevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more changes that should probably be made:

  • Don't think we should remove the * 5 when initializing BreakInfo, since all of the added blast resistances are also * 5. I'd rather just / 5 in the actual explosion code. I believe PM also does the same, would also be more consistent with BDS and whatnot. Also might cause issues if other areas of the code expect vanilla blast resistance values.

  • Better names for double7 and double8, especially just double, it doesn't make sense here. (assuming you took this from the Java code)

  • Exposure is not being utilized. (if it's not working as intended, you might want to fix it too)

  • Would remove the remaining debug code.

@JustTalDevelops
Copy link
Member

Make sure you resolve the Radius usage in main.go or remove the debugging code.

Copy link
Member

@JustTalDevelops JustTalDevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No knock-back to players (at least, in creative mode)

Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine mostly. Got a couple of comments that should be pretty easy to resolve.

server/block/explosion.go Outdated Show resolved Hide resolved
server/block/explosion.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small error in the refactor. Looks good otherwise, make sure to test once more to make sure all is right. Feel free to merge once you're confident it works.

server/block/model/thin.go Outdated Show resolved Hide resolved
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merge at your own discretion.

@JustTalDevelops JustTalDevelops merged commit b281564 into master Jul 29, 2022
@JustTalDevelops JustTalDevelops deleted the feature/explosions branch July 29, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants