Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented smithing tables #563

Merged
merged 7 commits into from
Jul 16, 2022
Merged

Implemented smithing tables #563

merged 7 commits into from
Jul 16, 2022

Conversation

JustTalDevelops
Copy link
Member

Closes #503.

@JustTalDevelops @DaPigGuy
Update server/session/handler_crafting.go
64ec9ea 
Co-authored-by: DaPigGuy <mcpepig123@gmail.com>
@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 14, 2022
@JustTalDevelops @DaPigGuy
Update server/session/handler_crafting.go
caf9a6d 
Co-authored-by: DaPigGuy <mcpepig123@gmail.com>
@DaPigGuy DaPigGuy mentioned this pull request Jul 14, 2022
Open
89 tasks
Sandertv
Sandertv reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority of this looks good, I'm just not super convinced we should have a WithType() method on item stacks, because it opens up a lot of things that aren't valid.

server/item/stack.go Outdated Show resolved Hide resolved
@JustTalDevelops
Copy link
Member Author

Is there anything else that can be changed here? @Sandertv

Sandertv
Sandertv approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Feel free to merge if you've properly tested this!

@JustTalDevelops JustTalDevelops merged commit 2cafec5 into master Jul 16, 2022
@JustTalDevelops JustTalDevelops deleted the feature/smithing-tables branch July 16, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy approved these changes

@Sandertv Sandertv Sandertv approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement smithing tables
3 participants
@JustTalDevelops @DaPigGuy @Sandertv