Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stonecutters #574

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Implement stonecutters #574

merged 6 commits into from
Jul 29, 2022

Conversation

JustTalDevelops
Copy link
Member

Closes #564.

This PR also makes recipes require a string block name, for a couple of reasons:

  • Stonecutters as a block go under the ID "stonecutter_block", but use "stonecutter" over the network.
  • Blocks with properties such as facing directions will not be properly loaded on start, since we don't have any data about the possible properties of the block, and instead assume nil for the properties.

@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 18, 2022
@JustTalDevelops JustTalDevelops mentioned this pull request Jul 18, 2022
Open
89 tasks
@DaPigGuy DaPigGuy requested a review from T14Raptor July 26, 2022 10:00
Sandertv
Sandertv approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Feel free to merge if it's been tested thoroughly.

@Sandertv
Copy link
Member

And when the conflicts have been resolved.

@JustTalDevelops
Copy link
Member Author

This should be ready now.

@JustTalDevelops JustTalDevelops merged commit 6078743 into master Jul 29, 2022
@JustTalDevelops JustTalDevelops deleted the feature/stonecutters branch July 29, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy approved these changes

@Sandertv Sandertv Sandertv approved these changes

@T14Raptor T14Raptor Awaiting requested review from T14Raptor

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement stonecutters
3 participants
@JustTalDevelops @Sandertv @DaPigGuy