Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented fireworks and firework stars #576

Merged
merged 15 commits into from
Jul 29, 2022
Merged

Implemented fireworks and firework stars #576

merged 15 commits into from
Jul 29, 2022

Conversation

JustTalDevelops
Copy link
Member

Also ensures that crafting outputs have their NBT data applied.

@DaPigGuy DaPigGuy mentioned this pull request Jul 19, 2022
Open
89 tasks
@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 19, 2022
DaPigGuy
DaPigGuy requested changes Jul 21, 2022
View reviewed changes
Copy link
Member

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firework rockets get stuck when spawned against a block, but otherwise looks good

@JustTalDevelops
Copy link
Member Author

Not too sure how to fix that, since technically the firework is within a block.

@JustTalDevelops JustTalDevelops added the awaiting response More information is required to resolve and/or close the issue label Jul 22, 2022
DaPigGuy
DaPigGuy requested changes Jul 24, 2022
View reviewed changes
Copy link
Member

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing entity damage on firework explode

@JustTalDevelops JustTalDevelops removed the awaiting response More information is required to resolve and/or close the issue label Jul 24, 2022
@JustTalDevelops
Copy link
Member Author

Implemented firework damage.

@JustTalDevelops JustTalDevelops changed the title Implemented fireworks Implemented fireworks and firework stars Jul 24, 2022
@DaPigGuy DaPigGuy requested a review from T14Raptor July 26, 2022 09:59
Sandertv
Sandertv requested changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine mostly. I got some minor comments.

server/entity/action.go Outdated Show resolved Hide resolved
server/entity/firework.go Outdated Show resolved Hide resolved
server/entity/firework.go Outdated Show resolved Hide resolved
server/item/firework.go Outdated Show resolved Hide resolved
server/item/firework_explosion.go Outdated Show resolved Hide resolved
Sandertv
Sandertv approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@Sandertv Sandertv merged commit 5d6a225 into master Jul 29, 2022
@Sandertv Sandertv deleted the feature/fireworks branch July 29, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy approved these changes

@Sandertv Sandertv Sandertv approved these changes

@T14Raptor T14Raptor Awaiting requested review from T14Raptor

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JustTalDevelops @DaPigGuy @Sandertv @T14Raptor