Implemented campfires #596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Campfires engite when flaming entity moves accross
Implemented Splash Potions having there own interface
Campfires now throw out cooked food Implemented Campfire Sounds Known Bugs (Campfires bug out when you click them, something to do with the Activate method)
DaPigGuy
reviewed
Jul 24, 2022
provsalt
approved these changes
Jul 25, 2022
87 tasks
* Disabled campfire vertical stacking
T14Raptor
reviewed
Jul 26, 2022
T14Raptor
reviewed
Jul 26, 2022
DaPigGuy
requested changes
Jul 26, 2022
DaPigGuy
reviewed
Jul 26, 2022
Co-authored-by: DaPigGuy <mcpepig123@gmail.com>
Co-authored-by: DaPigGuy <mcpepig123@gmail.com>
DaPigGuy
reviewed
Jul 26, 2022
… campfire and begin eating their food.
|
Make sure you fix the import cycle. |
…ampfire # Conflicts: # server/entity/splashable.go
This reverts commit 2277131.
DaPigGuy
approved these changes
Aug 10, 2022
Co-authored-by: DaPigGuy <mcpepig123@gmail.com>
DaPigGuy
reviewed
Aug 11, 2022
Co-authored-by: DaPigGuy <mcpepig123@gmail.com>
JustTalDevelops
approved these changes
Aug 11, 2022
Sandertv
reviewed
Aug 19, 2022
| @@ -141,6 +141,7 @@ func (h *InventoryTransactionHandler) handleUseItemTransaction(data *protocol.Us | |||
| s.c.BreakBlock(pos) | |||
| case protocol.UseItemActionClickBlock: | |||
| s.c.UseItemOnBlock(pos, cube.Face(data.BlockFace), vec32To64(data.ClickedPosition)) | |||
| s.c.UseItem() | |||
There was a problem hiding this comment.
Are you sure this is a correct change? This sounds like a change that has quite some implications.
There was a problem hiding this comment.
Tal recommened I make that change. This was added in order to fix every raw food type that interacted with the campfire from instantly getting placed. The ideal behavior here is for each click to add a signular raw food type onto the campfire. I'm not really sure how to attain this behaviour.
There was a problem hiding this comment.
@JustTalDevelops could you elaborate on this? I'm not entirely sure what the issue is here.
DaPigGuy
reviewed
Aug 20, 2022
DaPigGuy
force-pushed
the
feature/campfire
branch
from
b4b1fbc
to
6016986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Campfires!