Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement the milk bucket. #598

Merged
merged 6 commits into from
Aug 1, 2022
Merged

implement the milk bucket. #598

merged 6 commits into from
Aug 1, 2022

Conversation

RestartFU
Copy link
Contributor

No description provided.

@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 25, 2022
@Sandertv
Copy link
Member

I don't think having a separate MilkBucket and LiquidBucket type is the right approach for this given the rest of the item/block design. Maybe we should have a Content BucketContent(Type) field and have BucketContent be either LiquidContent(world.Liquid), MilkContent() (or, later on, FishContent(...))

@RestartFU
Copy link
Contributor Author

I don't think having a separate MilkBucket and LiquidBucket type is the right approach for this given the rest of the item/block design. Maybe we should have a Content BucketContent(Type) field and have BucketContent be either LiquidContent(world.Liquid), MilkContent() (or, later on, FishContent(...))

I just did a commit, I don't think that my implementation is great, since we need to make it a consumable, even when its content isn't milk.

Sandertv
Sandertv requested changes Aug 1, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change is pretty much exactly what I had in mind. I've got one thing to rename, but this should be good to go afterwards.

server/item/bucket.go Outdated Show resolved Hide resolved
Sandertv
Sandertv approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the PR!

@Sandertv Sandertv merged commit 3705e68 into df-mc:master Aug 1, 2022
@DaPigGuy DaPigGuy mentioned this pull request Aug 1, 2022
Open
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustTalDevelops JustTalDevelops JustTalDevelops approved these changes

@Sandertv Sandertv Sandertv approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RestartFU @Sandertv @JustTalDevelops @DaPigGuy