Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Books and Quills + Written Book #608

Merged
merged 35 commits into from
Aug 20, 2022
Merged

Implemented Books and Quills + Written Book #608

merged 35 commits into from
Aug 20, 2022

Conversation

abimek
Copy link
Contributor

@abimek abimek commented Jul 28, 2022 •
edited
Loading

Complete

@abimek
Implemented Books and Quills + Written Book
6ea616f 
Will need to implement the crafting recipes for written books
@abimek
fixing checks
4bc9bb0
TwistedAsylumMC
TwistedAsylumMC requested changes Jul 28, 2022
View reviewed changes
server/item/register.go Outdated Show resolved Hide resolved
server/item/writable_book.go Outdated Show resolved Hide resolved
server/item/writable_book.go Outdated Show resolved Hide resolved
server/item/writable_book.go Outdated Show resolved Hide resolved
server/item/writable_book.go Outdated Show resolved Hide resolved
server/item/written_book.go Outdated Show resolved Hide resolved
server/session/handler_book_edit.go Show resolved Hide resolved
server/session/handler_book_edit.go Outdated Show resolved Hide resolved
server/session/handler_book_edit.go Show resolved Hide resolved
server/session/handler_book_edit.go Outdated Show resolved Hide resolved
T14Raptor
T14Raptor reviewed Jul 28, 2022
View reviewed changes
server/item/writable_book.go Outdated Show resolved Hide resolved
server/item/writable_book.go Outdated Show resolved Hide resolved
server/item/writable_book.go Outdated Show resolved Hide resolved
@DaPigGuy DaPigGuy mentioned this pull request Jul 28, 2022
Open
89 tasks
@abimek
Reordered register.go
94a7650 
Added missing docs for WritableBook and WrittenBook
Removed uint in preference of int
@abimek
Documentation Fixes + Code Fixes
3678996 
Returning WritableBook on (WritableBook).Set() and (WritableBook).Swap()
@abimek
Removal of Unnecessary Glinted Field
ab0028c
@abimek
Doc update
81f3efe
@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 29, 2022
@TwistedAsylumMC TwistedAsylumMC self-requested a review August 2, 2022 17:42
abimek and others added 7 commits August 10, 2022 21:07
Sandertv
Sandertv requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I've got a couple more comments. Once these are resolved, this is probably ready to go. Nice work.

server/session/handler_book_edit.go Show resolved Hide resolved
server/session/handler_book_edit.go Show resolved Hide resolved
server/session/handler_book_edit.go Outdated Show resolved Hide resolved
server/item/written_book.go Outdated Show resolved Hide resolved
server/item/book_and_quill.go Outdated Show resolved Hide resolved
@DaPigGuy DaPigGuy merged commit c7dab95 into df-mc:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy approved these changes

@Sandertv Sandertv Sandertv requested changes

@TwistedAsylumMC TwistedAsylumMC Awaiting requested review from TwistedAsylumMC

@JustTalDevelops JustTalDevelops Awaiting requested review from JustTalDevelops

@T14Raptor T14Raptor Awaiting requested review from T14Raptor

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@abimek @DaPigGuy @Sandertv @TwistedAsylumMC @JustTalDevelops @T14Raptor