-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented lecterns #651
Implemented lecterns #651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine mostly. I'm only not sure about the NBT "tag" changes. What are those based on?
The NBT changes are based on vanilla Minecraft. Everything that does not define the item type goes inside the tag field. You can see this in Gophertunnel. |
# Conflicts: # go.mod # go.sum # server/internal/nbtconv/mapread.go # server/internal/nbtconv/read.go
This should be ready for review now. |
# Conflicts: # server/player/handler.go # server/player/player.go # server/session/controllable.go
No description provided.