Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented lecterns #651

Merged
merged 8 commits into from
Jul 4, 2023
Merged

Implemented lecterns #651

merged 8 commits into from
Jul 4, 2023

Conversation

JustTalDevelops
Copy link
Member

No description provided.

@JustTalDevelops JustTalDevelops added the feature New feature or request label Aug 20, 2022
@DaPigGuy DaPigGuy requested a review from Sandertv August 21, 2022 05:54
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine mostly. I'm only not sure about the NBT "tag" changes. What are those based on?

server/block/lectern.go Show resolved Hide resolved
server/block/lectern.go Outdated Show resolved Hide resolved
server/block/model/lectern.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
server/session/controllable.go Outdated Show resolved Hide resolved
server/session/handler_lectern_update.go Outdated Show resolved Hide resolved
server/internal/nbtconv/mapread.go Outdated Show resolved Hide resolved
@JustTalDevelops
Copy link
Member Author

JustTalDevelops commented Oct 23, 2022

The NBT changes are based on vanilla Minecraft. Everything that does not define the item type goes inside the tag field. You can see this in Gophertunnel.

# Conflicts:
#	go.mod
#	go.sum
#	server/internal/nbtconv/mapread.go
#	server/internal/nbtconv/read.go
@JustTalDevelops
Copy link
Member Author

This should be ready for review now.

server/player/player.go Outdated Show resolved Hide resolved
# Conflicts:
#	server/player/handler.go
#	server/player/player.go
#	server/session/controllable.go
@TwistedAsylumMC TwistedAsylumMC merged commit 24f3a3c into master Jul 4, 2023
4 checks passed
@TwistedAsylumMC TwistedAsylumMC deleted the feature/lectern branch July 4, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants