Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented the Curse of Vanishing enchantment #661

Merged
merged 14 commits into from
Aug 29, 2022
Merged

Implemented the Curse of Vanishing enchantment #661

merged 14 commits into from
Aug 29, 2022

Conversation

eminarican
Copy link
Contributor

(not sure about enchantment cost)

JustTalDevelops
JustTalDevelops requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@JustTalDevelops JustTalDevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've left a few comments, please address them whenever possible.

server/item/enchantment/vanishing.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
server/item/enchantment/vanishing.go Outdated Show resolved Hide resolved
@JustTalDevelops JustTalDevelops changed the title vanish enchantment Implemented the Curse of Vanishing enchantment Aug 29, 2022
@JustTalDevelops JustTalDevelops added the feature New feature or request label Aug 29, 2022
DaPigGuy
DaPigGuy requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grindstones need to be changed to not remove curse enchantments

DaPigGuy
DaPigGuy requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@DaPigGuy DaPigGuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments,

server/item/enchantment/vanishing.go Outdated Show resolved Hide resolved
@DaPigGuy DaPigGuy mentioned this pull request Aug 29, 2022
Open
89 tasks
@eminarican eminarican requested review from DaPigGuy and JustTalDevelops and removed request for DaPigGuy August 29, 2022 06:33
@eminarican eminarican requested review from DaPigGuy and removed request for JustTalDevelops August 29, 2022 16:18
DaPigGuy
DaPigGuy requested changes Aug 29, 2022
View reviewed changes
server/session/handler_grindstone.go Outdated Show resolved Hide resolved
@DaPigGuy DaPigGuy merged commit 00a8340 into df-mc:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustTalDevelops JustTalDevelops JustTalDevelops approved these changes

@DaPigGuy DaPigGuy Awaiting requested review from DaPigGuy

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eminarican @DaPigGuy @JustTalDevelops