Enable executing FIFO tasks on a desired actor's execution context #6
Conversation
dfed
force-pushed
the
dfed--isolated-fifo-task
branch
from
19e2f43
to
ada5638
Compare
| await systemUnderTest.await { /* Drain the queue */ } | ||
| } | ||
|
|
||
| func test_await_async_areNotReentrant() async { |
There was a problem hiding this comment.
this test was previously called test_async_isNotReentrant, but technically it was testing that await and async aren't reentrant rather than just testing that async is not reentrant.
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 7 7
Lines 489 703 +214
==========================================
+ Hits 489 703 +214
|
dfed
force-pushed
the
dfed--isolated-fifo-task
branch
from
ada5638
to
992261b
Compare
| @@ -46,6 +46,32 @@ final class FIFOQueueTests: XCTestCase { | |||
| await systemUnderTest.await { /* Drain the queue */ } | |||
| } | |||
|
|
|||
| func test_asyncOn_sendsEventsInOrder() async { | |||
There was a problem hiding this comment.
Most of these new tests mirror the tests directly above them that tested the API without the on isolatedActor parameter.
dfed
force-pushed
the
dfed--isolated-fifo-task
branch
from
992261b
to
4b3dde6
Compare
dfed
force-pushed
the
dfed--isolated-fifo-task
branch
from
4b3dde6
to
c1aa546
Compare
dfed
changed the title
dfed
changed the title
Sources/AsyncQueue/FIFOQueue.swift
Outdated
| @@ -58,6 +58,15 @@ public final class FIFOQueue: Sendable { | |||
| taskStreamContinuation.yield(task) | |||
| } | |||
|
|
|||
| /// Schedules an asynchronous task for execution and immediately returns. | |||
| /// The scheduled task will not execute until all prior tasks have completed or suspended. | |||
There was a problem hiding this comment.
This is the FIFO queue so don't we only want this task to execute after all prior tasks have completed?
Sources/AsyncQueue/FIFOQueue.swift
Outdated
| @@ -70,6 +79,20 @@ public final class FIFOQueue: Sendable { | |||
| } | |||
| } | |||
|
|
|||
| /// Schedules an asynchronous task and returns after the task is complete. | |||
| /// The scheduled task will not execute until all prior tasks have completed or suspended. | |||
There was a problem hiding this comment.
Same comment as above. My understanding of FIFO queue was that we only wanted a task to execute after the prior tasks completed.
Sources/AsyncQueue/FIFOQueue.swift
Outdated
| @@ -86,6 +109,24 @@ public final class FIFOQueue: Sendable { | |||
| } | |||
| } | |||
|
|
|||
| /// Schedules an asynchronous throwing task and returns after the task is complete. | |||
| /// The scheduled task will not execute until all prior tasks have completed or suspended. | |||
| let counter = Counter() | ||
| for iteration in 1...1_000 { | ||
| systemUnderTest.async(on: counter) { counter in | ||
| counter.incrementAndExpectCount(equals: iteration) |
There was a problem hiding this comment.
Very nice that you don't need to await.
| await systemUnderTest.await { /* Drain the queue */ } | ||
| } | ||
|
|
||
| func test_async_asyncOn_sendEventsInOrder() async { |
| semaphore.signal() | ||
| } | ||
| // Wait for the concurrent task to complete. | ||
| await semaphore.wait() |
There was a problem hiding this comment.
Here we still need an await since wait() may suspend. Is that right?
There was a problem hiding this comment.
Correct! wait is an async (i.e. possibly suspending) method on the semaphore, whereas signal is not. So we need to await the async method.
|
|
||
| await systemUnderTest.await(on: counter) { counter in | ||
| let count = counter.count | ||
| XCTAssertEqual(count, iteration) |
This PR adds API to the
FIFOQueuethat enablestasks sent to the queue to execute within a particularactor's context.The benefits of this API are:
actor-conforming type can be executed without requiring multiple suspensions.async-decorated properties and methods on a givenactorrequires theawaitkeyword, enabling the casual reader to distinguish which tasks will execute synchronously and which may suspend.