Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFetch doesn't warn if patch file doesn't exist #191

Closed
ben-edna opened this issue Jul 7, 2021 · 0 comments · Fixed by #192
Closed

DFetch doesn't warn if patch file doesn't exist #191

ben-edna opened this issue Jul 7, 2021 · 0 comments · Fixed by #192
Assignees
Labels
bug Something isn't working UX Not broken, but frustrating/unclear for users

Comments

@ben-edna
Copy link
Contributor

ben-edna commented Jul 7, 2021

In

if self.__project.patch and os.path.exists(self.__project.patch):
is checked if the patch file exist, but if the path is incorrect, DFetch silently continuous.

Maybe something along the lines of:

if self.__project.patch:
    if os.path.exists(self.__project.patch):
        self.apply_patch()
    else:
        logger.warning(f"Skipping non-existent patch {self.__project.patch}")
@ben-edna ben-edna added bug Something isn't working UX Not broken, but frustrating/unclear for users labels Jul 7, 2021
@jgeudens jgeudens self-assigned this Jul 7, 2021
jgeudens added a commit to jgeudens/dfetch that referenced this issue Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX Not broken, but frustrating/unclear for users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants