Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If completely unrelated name is given, suggestion crashes #358

Closed
spoorcc opened this issue Jul 28, 2022 · 0 comments
Closed

If completely unrelated name is given, suggestion crashes #358

spoorcc opened this issue Jul 28, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@spoorcc
Copy link
Contributor

spoorcc commented Jul 28, 2022

If a project name is given that doesn't resemble any other name, no suggestion can be created in _guess_project.

https://github.com/dfetch-org/dfetch/blob/main/dfetch/manifest/manifest.py#L74

difflib.get_close_matches can return an empty list
@spoorcc spoorcc added the bug Something isn't working label Jul 28, 2022
spoorcc added a commit that referenced this issue Oct 7, 2022
@spoorcc
Fixes #358: If suggestion not found, crash
6afb2a5
@spoorcc spoorcc closed this as completed in 817881e Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spoorcc