Bug Fixed: No. of questions that can be accepted #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,7 @@ class AdminGui(Gui): | |||
| mutePlayers = pyqtSignal(list) | |||
| unmutePlayers = pyqtSignal(list) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Nit: could you remove this empty line? :)
|
There a few minor comments, but otherwise LGTM. Thank you! 👍 |
dfilimon
added a commit
that referenced
this pull request
Apr 1, 2013
Bug Fixed: No. of questions that can be accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a response to the bug submitted by mihaimaruseac, i have limited the numbers of questions that can be accepted by the admin. If another question is chosen by any other player, it can only be rejected in order not to accidentally skip one of them. I also added in the message box the name of the player who picked the question, so that the admin can accept the right question.
To get the number of questions picked, i have added each one in a stack, and as soon as it is processed(accepted or refused) it is poped it out. When a new question is picked, the length of the stack is evaluated and a proper message is displayed.