Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate AssetManager to @dfinity/assets #602

Closed
sea-snake opened this issue Jul 28, 2022 · 0 comments · Fixed by #603
Closed

Migrate AssetManager to @dfinity/assets #602

sea-snake opened this issue Jul 28, 2022 · 0 comments · Fixed by #603

Comments

@sea-snake
Copy link
Contributor

Currently there's the AssetManager implementation available here.

This issue is regarding improving on this implementation and moving it to @dfinity/assets.

The AssetManager has list, store, delete, get, batch and clear methods to manage assets in an asset storage canister.
slide-computer pushed a commit to slide-computer/agent-js that referenced this issue Jul 28, 2022
@sea-snake
feat: add AssetManager
d35f95a 
Closes dfinity#602
@sea-snake sea-snake mentioned this issue Jul 28, 2022
Merged
4 tasks
krpeacock added a commit that referenced this issue Oct 5, 2022
@sea-snake @krpeacock
feat: add AssetManager (#603)
a3b3224 
* First AssetManager implementation

Closes #602

* Update @dfinity/assets readme and changelog

* Remove browsers tests, already covered by node tests

* Fix linting issues, update jest and ts configs, update JS docs and add null check to isReadable.

* Close Node.js write handle after writing chunks and add additional Node.js file read/write to/from asset canister test.

* Decrease test asset size to reduce E2E test duration.

Co-authored-by: Kyle Peacock <kylpeacock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add AssetManager slide-computer/agent-js
1 participant
@sea-snake