Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update webappsec types dependency #537

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

jzxchiang1
Copy link
Contributor

@jzxchiang1 jzxchiang1 commented Feb 20, 2022

Actually, the CredentialCreationOptions type from this package is in the public interface of the @dfinity/identity package, so it should be part of the dependencies, not the devDependencies (because otherwise if it's part of the latter, like right now, it won't get transitively installed by users of @dfinity/identity, causing tsc errors for users).

See these links for details:

@jzxchiang1 jzxchiang1 changed the title Update package.json fix: Update package.json dependency Feb 23, 2022
@jzxchiang1 jzxchiang1 changed the title fix: Update package.json dependency fix: Update webappsec types dependency Feb 23, 2022
@jzxchiang1
Copy link
Contributor Author

Can someone rerun this? I don't know why it's failing.

@krpeacock krpeacock merged commit f9bfa59 into dfinity:main Mar 25, 2022
@krpeacock
Copy link
Contributor

Yeah, the CI issue was unrelated. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants