Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: homepage/repository in package.json #569

Merged
merged 3 commits into from
May 18, 2022

Conversation

domwoe
Copy link
Member

@domwoe domwoe commented May 5, 2022

Signed-off-by: Dominic Woerner dominic.woerner@dfinity.org

Description

Homepage link in npm registry was broken and link to repository/package and issue tracking was missing.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

…json

Signed-off-by: Dominic Woerner <dominic.woerner@dfinity.org>
@dfinity-droid-prod
Copy link

Dear @domwoe,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@domwoe
Copy link
Member Author

domwoe commented May 11, 2022

@krpeacock Would you take a look? :)

"repository": {
"type": "git",
"url": "https://github.com/dfinity/agent-js.git",
"directory": "packages/agent"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the directory config is correct - this package.json already lives inside packages/agent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, the directory refers just to the repo given by the url above, i.e. the base repo, and has nothing to do with the package.json.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krpeacock
Copy link
Contributor

Thanks for opening this! One note about the repository/directory configs before we accept this

@krpeacock krpeacock self-requested a review May 18, 2022 19:48
@krpeacock krpeacock enabled auto-merge (squash) May 18, 2022 20:50
@krpeacock krpeacock merged commit d7e7df1 into dfinity:main May 18, 2022
@domwoe domwoe deleted the fix/npm-info-in-package-json branch May 19, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants