-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: homepage/repository in package.json #569
Conversation
…json Signed-off-by: Dominic Woerner <dominic.woerner@dfinity.org>
Dear @domwoe, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1. If you decide to agree with it, please visit this issue and read the instructions there. — The DFINITY Foundation Footnotes
|
@krpeacock Would you take a look? :) |
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/dfinity/agent-js.git", | ||
"directory": "packages/agent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the directory config is correct - this package.json already lives inside packages/agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, the directory
refers just to the repo given by the url
above, i.e. the base repo, and has nothing to do with the package.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this! One note about the repository/directory configs before we accept this |
Signed-off-by: Dominic Woerner dominic.woerner@dfinity.org
Description
Homepage link in npm registry was broken and link to repository/package and issue tracking was missing.
Checklist: