Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add setBigUint64 polyfill #577

Merged
merged 3 commits into from
Jun 3, 2022
Merged

fix: add setBigUint64 polyfill #577

merged 3 commits into from
Jun 3, 2022

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Jun 2, 2022

Description

Adds the setBigUint64 polyfill because of the multiple error reports. (based on nns-dapp solution)

@mstrasinskis mstrasinskis marked this pull request as ready for review June 2, 2022 10:01
Copy link
Contributor

@dfx-json dfx-json left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mstrasinskis. The proposed changes look good. The only thing I would like to know is how we can verify lines 118 and 119 produce a result equivalent to line 115 (types.ts)? Could you perhaps add one more test? Thank you!

@mstrasinskis
Copy link
Contributor Author

Good point, @dfx-json. The test was replaced. Consistency of results is the only important characteristic of the polyfill.

@nmattia
Copy link
Contributor

nmattia commented Jun 3, 2022

merging on behalf of @bitdivine , apparently GitHub is having a slow day!

@nmattia nmattia merged commit 3a907af into main Jun 3, 2022
@nmattia nmattia deleted the fix-ios14-no-setBigUint64 branch June 3, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants