Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graceful upgrade from localstorage to idb without breaking sessions #606

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Aug 11, 2022

Description

This change makes the upgrade to IDB smoother, by checking to see if the user has a delegation stored in localstorage during initialization, if none is found in the default or provided storage implementation.

How Has This Been Tested?

unit testing

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner August 11, 2022 20:23
@krpeacock krpeacock merged commit b550f81 into main Aug 11, 2022
@krpeacock krpeacock deleted the kyle/graceful-localstorage-migration branch August 11, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants