feat: retry query signature verification in case cache is stale #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
ShuoWangNSL
reviewed
Nov 16, 2023
ShuoWangNSL
reviewed
Nov 16, 2023
ShuoWangNSL
reviewed
Nov 16, 2023
|
It's throwing an error, but not in a way that the mitm test is detecting as a "rejection" I need to investigate a bit further |
| 'Invalid signature from replica signed query: no matching node key found.', | ||
| ); | ||
| } | ||
| return this.#verifyQueryResponse(query, updatedSubnetStatus); |
There was a problem hiding this comment.
Is it okay that there is no resolve(subnetStatus); call here, in between get and verifyQueryResponse, as in the above code?
There was a problem hiding this comment.
Yes, we are not within a Promise at this stage in the code (apart from the async query function itself). It's a little semantically incongruous if you're comparing this section to the above sections, however
ericswanson-dfinity
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because a node can be upgraded while the cache is stale, we should retry a failed query signature verification once, after refreshing the cache
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: