Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: distinguish remote dev environments from known hosts #830

Merged
merged 6 commits into from Jan 23, 2024
Merged

fix: distinguish remote dev environments from known hosts #830

merged 6 commits into from Jan 23, 2024

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Jan 23, 2024

Description

Follow-up for this forum conversation with improved test coverage.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@rvanasa rvanasa requested a review from a team as a code owner January 23, 2024 18:12
@rvanasa rvanasa marked this pull request as draft January 23, 2024 18:37
@rvanasa rvanasa marked this pull request as ready for review January 23, 2024 19:39
@krpeacock krpeacock merged commit e0aea69 into dfinity:main Jan 23, 2024
15 checks passed
@rvanasa rvanasa deleted the fix-known-remote-hosts branch January 23, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krpeacock krpeacock krpeacock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvanasa @krpeacock