Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customPath changes #840

Merged
merged 5 commits into from
Feb 3, 2024
Merged

feat: customPath changes #840

merged 5 commits into from
Feb 3, 2024

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Feb 2, 2024

Description

feat: new CustomPath class, better docs, and deprecating metadata path type for CanisterStatus

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 2, 2024 23:50
Copy link
Contributor

github-actions bot commented Feb 2, 2024

size-limit report 📦

Path Size
@dfinity/agent 99.87 KB (+0.04% 🔺)
@dfinity/candid 13.61 KB (0%)
@dfinity/principal 5.04 KB (0%)
@dfinity/auth-client 91.73 KB (0%)
@dfinity/assets 91.93 KB (0%)
@dfinity/identity 89.05 KB (0%)
@dfinity/identity-secp256k1 262.87 KB (-0.03% 🔽)

@krpeacock
Copy link
Contributor Author

Sorry for the chaotic PR - there were some exploratory changes left over from SDK-1219 when I thought this file was only modified from the CustomPath portion

@krpeacock krpeacock enabled auto-merge (squash) February 3, 2024 00:16
@krpeacock krpeacock merged commit 1c6a6aa into main Feb 3, 2024
15 checks passed
@krpeacock krpeacock deleted the kai/custompath-changes branch February 3, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants