Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export AuthClientStorage to aid with custom implementations #848

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

hpeebles
Copy link
Contributor

@hpeebles hpeebles commented Feb 15, 2024

Description

By exporting the AuthClientStorage interface, users can easily create custom implementations of it.

How Has This Been Tested?

It doesn't need to be tested given that all it does is export a type which was previously private.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@hpeebles hpeebles requested a review from a team as a code owner February 15, 2024 14:21
@hpeebles hpeebles changed the title feat: export AuthClientStorage to support custom implementations chore: export AuthClientStorage to support custom implementations Feb 15, 2024
@hpeebles hpeebles changed the title chore: export AuthClientStorage to support custom implementations chore: export AuthClientStorage to aid with custom implementations Feb 15, 2024
@krpeacock krpeacock merged commit 166df8d into dfinity:main Feb 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants